shapez/gulp
LeopoldTal ff2274f671
fix size overflow when building sounds (#676)
Building the standalone with V8 v8 (Node v14) fails at step `sounds.musicHQ`, either by running out of memory or with the error "Invalid string length". Building with V8 v7 (Node v12) succeeds.

This is because `gulp-cache` builds a 994-MB string when [stringifying file contents](https://github.com/jgable/gulp-cache/blob/master/src/task-proxy.js#L262) to cache them. V8 v8 [limits string length to around 537 MB](https://github.com/v8/v8/blob/master/src/objects/string.h#L384), and thus cannot represent this string. (V8 v7 allows around 1074 MB, which is why the build passes on Node v12.)

But [`theme-full.mp3`](https://github.com/tobspr/shapez.io/blob/master/res_raw/sounds/music/theme-full.mp3) is only 79 MB: how did we get 1250% overhead?

Unlike plaintext files, binary files are read as buffers, but [by default](https://github.com/jgable/gulp-cache/blob/master/src/index.js#L46) `gulp-cache` stringifies them naively, producing the extremely inefficient representation:

````
[
  {
    "cwd": "/Users/tobspr/shapez.io/gulp",
    "base": "/Users/tobspr/shapez.io/res_raw/sounds/music",
    "contents": {
      "type": "Buffer",
      "data": [
        73,
        68,
        51,
        4,
        0,
        0,
…etc.
````

Fortunately, `gulp-cache` [can read base64-encoded cache files](https://github.com/jgable/gulp-cache/blob/master/src/index.js#L26).

Instead of using the default file transform function, **pass a `value` option to base64-encode the file contents**. This results in only 33% overhead on cache file size (106 MB for the largest file).

This has multiple benefits:

- Fixes the build failure
- Requires less memory (from 6 GB down to < 1 GB on my machine)
- When cache files are found, the `sounds.musicHQ` is much faster (from ~30 s down to ~4 s on my machine)
- Smaller cache files on disk
2020-09-21 08:37:50 +02:00
..
.babelrc Remove source maps and adjust targets 2020-05-15 09:09:37 +02:00
.gitattributes Initial commit 2020-05-09 16:45:23 +02:00
.gitignore Minor fix for the standalone 2020-05-29 08:18:40 +02:00
.itch.toml Add .itch.toml file 2020-05-30 20:25:46 +02:00
babel-es6.config.js Remove source maps and adjust targets 2020-05-15 09:09:37 +02:00
babel.config.js Remove source maps and adjust targets 2020-05-15 09:09:37 +02:00
buildutils.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
bundle-loader.js Initial commit 2020-05-09 16:45:23 +02:00
convert_atlas.js Initial commit 2020-05-09 16:45:23 +02:00
cordova.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
css.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
docs.js Switch to gulp 4 2020-06-13 18:59:25 +03:00
ftp.js Add alpha build functionality 2020-07-05 12:54:43 +02:00
gulpfile.js Add alpha build functionality 2020-07-05 12:54:43 +02:00
html.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
image-resources.js Use gulp.parallel instead of gulp-multi-process 2020-06-13 21:44:00 +03:00
js.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
jsconfig.json Initial commit 2020-05-09 16:45:23 +02:00
loader.compressjson.js Initial commit 2020-05-09 16:45:23 +02:00
loader.strip_block.js Initial commit 2020-05-09 16:45:23 +02:00
package.json Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
sounds.js fix size overflow when building sounds (#676) 2020-09-21 08:37:50 +02:00
standalone.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
translations.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
tsconfig.json Initial commit 2020-05-09 16:45:23 +02:00
webpack.config.js Revert worker loader change 2020-08-10 19:54:11 +02:00
webpack.production.config.js Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00
yarn.lock Remove more unused dependencies (#527) 2020-08-07 09:16:23 +02:00