Properly handle error on stop and start daemons

controllers/internals/Console.php

@@ -14,11 +14,11 @@ namespace controllers\internals;
 use DateInterval;
 use Faker\Factory;
 
-    /**
+/**
  * Class to call the console scripts.
  */
-    class Console extends \descartes\InternalController
-    {
+class Console extends \descartes\InternalController
+{
     /**
      * Start launcher daemon.
      */

daemons/AbstractDaemon.php

@@ -150,12 +150,12 @@ abstract class AbstractDaemon
         //Write the pid of the process into a file
         file_put_contents($this->pid_dir . '/' . $this->name . '.pid', getmypid());
 
-        //Really start the daemon
-        $this->on_start();
-
               
         try
         {
+            //Really start the daemon
+            $this->on_start();
+
             while ($this->is_running)
             {
                 
@@ -168,7 +168,8 @@ abstract class AbstractDaemon
             $this->logger->critical('Exception : ' . $t->getMessage() . ' in ' . $t->getFile() . ' line ' . $t->getLine());
             $exit_code = $t->getCode() ?: 1; 
         }
-
+        finally
+        {
             //Stop the daemon
             $this->on_stop();
 
@@ -180,6 +181,7 @@ abstract class AbstractDaemon
 
             exit($exit_code ?? 0);
         }
+    }
 
     /**
      * Override to implement the code that run infinetly (actually, it run one time but repeat the operation infinetly.