Fix #495

smalltalk fix argv

api/src/index.js

@@ -35,6 +35,7 @@ expressWs(app);
             }
         }
     });
+    fss.chmodSync(path.join(config.data_directory, globals.data_directories.jobs), 0o711)
 
     logger.info('Loading packages');
     const pkgdir = path.join(

api/src/job.js

@@ -344,6 +344,9 @@ class Job {
                     
                     const proc_id_int = parse_int(proc_id);
                     
+                    // Skip over any processes that aren't ours.
+                    if(ruid != this.uid && euid != this.uid) return -1; 
+
                     if (state == 'Z'){
                         // Zombie process, just needs to be waited, regardless of the user id
                         if(!to_wait.includes(proc_id_int))
@@ -353,8 +356,7 @@ class Job {
                     }
                     // We should kill in all other state (Sleep, Stopped & Running)
 
-                    if (ruid == this.uid || euid == this.uid)
-                        return proc_id_int;
+                    return proc_id_int;
                 } catch {
                     return -1;
                 }

docker-compose.dev.yaml

@@ -10,11 +10,11 @@ services:
         ports:
             - 2000:2000
         volumes:
-            - ./data/piston:/piston
+            - ./data/piston/packages:/piston/packages
         environment:
             - PISTON_REPO_URL=http://repo:8000/index
         tmpfs:
-            - /piston/jobs:exec
+            - /piston/jobs:exec,uid=1000,gid=1000,mode=711
 
     repo: # Local testing of packages
         build: repo

docker-compose.yaml

@@ -8,7 +8,7 @@ services:
         ports:
             - 2000:2000
         volumes:
-            - ./data/piston:/piston
+            - ./data/piston/packages:/piston/packages
         tmpfs:
-            - /piston/jobs:exec,uid=1000,gid=1000,mode=700
+            - /piston/jobs:exec,uid=1000,gid=1000,mode=711
             - /tmp:exec

packages/smalltalk/3.2.3/run

@@ -4,5 +4,5 @@ code_file=`pwd`/"$1"
 shift
 
 cd $SMALLTALK_PATH
-$SMALLTALK_PATH/gst "$code_file" "$@"
+$SMALLTALK_PATH/gst "$code_file" -a "$@"
 

piston

@@ -14,13 +14,6 @@ docker_compose(){
     fi
 }
 
-init_precommit() {
-    if [ $PISTON_ENV == "dev" ]; then
-        rm -f .git/hooks/pre-commit
-        ln -s "$PISTON_PATH/pre-commit" "$PISTON_PATH/.git/hooks/pre-commit"
-    fi
-}
-
 case $1 in
     help)
         echo "=== Piston Management ==="
@@ -66,14 +59,12 @@ case $1 in
 
     restart) docker_compose restart ;;
     start)
-        init_precommit
         docker_compose up -d
         ;;
     stop) docker_compose down ;;
     bash) docker_compose exec api /bin/bash ;;
 
     rebuild)
-        init_precommit
         docker_compose build && docker_compose up -d
         ;;
 

readme.md

@@ -71,6 +71,7 @@ The following are approved and endorsed extensions/utilities to the core Piston
 -   [Pyston](https://github.com/ffaanngg/pyston), a Python wrapper for accessing the Piston API.
 -   [Go-Piston](https://github.com/milindmadhukar/go-piston), a Golang wrapper for accessing the Piston API.
 -   [piston_rs](https://github.com/Jonxslays/piston_rs), a Rust wrapper for accessing the Piston API.
+-   [piston_rspy](https://github.com/Jonxslays/piston_rspy), Python bindings for accessing the Piston API via `piston_rs`.
 
 <br>