Mascali
/
piston
mirror of https://github.com/engineer-man/piston.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Comments explaining the try-catch flow

This commit is contained in:
Omar Brikaa 2023-09-16 21:37:09 +03:00
parent 040e19fdc2
commit 6a47869578
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/src/api/v2.js
View File

@ -230,7 +230,7 @@ router.ws('/connect', async (ws, req) => {
} finally { } finally {
await job.cleanup(); await job.cleanup();
} }
ws.close(4999, 'Job Completed'); ws.close(4999, 'Job Completed'); // Will not execute if an error is thrown above
} else { } else {
ws.close(4000, 'Already Initialized'); ws.close(4000, 'Already Initialized');
} }
@ -293,10 +293,10 @@ router.post('/execute', async (req, res) => {
return res.status(500).send(); return res.status(500).send();
} finally { } finally {
try { try {
await job.cleanup(); await job.cleanup(); // This gets executed before the returns in try/catch
} catch (error) { } catch (error) {
logger.error(`Error cleaning up job: ${job.uuid}:\n${error}`); logger.error(`Error cleaning up job: ${job.uuid}:\n${error}`);
return res.status(500).send(); return res.status(500).send(); // On error, this replaces the return in the outer try-catch
} }
} }
}); });