From 2b21e14c2c69d1c747d1a349c365521d2f877054 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=A4der?= Date: Mon, 13 Jan 2020 18:14:23 +0100 Subject: [PATCH 1/3] Check that `develop` is target in PR This is an update to the PR template. It mostly adds text and some checks related to how good the template is filled in and whether the `develop` branch was selected as base. --- .github/pull_request_template.md | 46 +++++++++++++++++++++++++++----- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1c3885f..792055a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,13 +1,31 @@ + + -But if there is already a related issue, please put it's number here. E.g. #123 or N/A --> Related Issue: ## New Behavior ... @@ -15,7 +33,8 @@ please describe in a few words the behavior your PR implements ## Contrast to Current Behavior ... @@ -24,12 +43,15 @@ please describe in a few words how the new behavior is different from the curren ... @@ -38,7 +60,17 @@ Please make your case here: ... + +## Double Check + + + +* [ ] I have read the comments and followed the PR template. +* [ ] I have provided a explained my PR according to the information in the comments. +* [ ] My PR targets the `develop` branch. From 1bad9b4fa89639e205472f49d5a0e8f7e41be8fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=A4der?= Date: Mon, 13 Jan 2020 18:24:51 +0100 Subject: [PATCH 2/3] Fix typo in pull request template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 792055a..6f755c3 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -72,5 +72,5 @@ Please put an x into the brackets (like `[x]`) if you've completed that task. --> * [ ] I have read the comments and followed the PR template. -* [ ] I have provided a explained my PR according to the information in the comments. +* [ ] I have provided and explained my PR according to the information in the comments. * [ ] My PR targets the `develop` branch. From 8892ea99369ae6115d47588886373179b51232a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=A4der?= Date: Sat, 18 Jan 2020 11:48:08 +0100 Subject: [PATCH 3/3] Ask for a release note entry --- .github/pull_request_template.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6f755c3..32b34f0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -65,6 +65,15 @@ If the Wiki must be updated, please make a suggestion below. ... +## Proposed Release Note Entry + + + +... + ## Double Check