From 7df5da38bf69f6639219918102f14fc2801b4d7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=A4der?= Date: Tue, 10 Dec 2019 23:09:43 +0100 Subject: [PATCH 1/2] Pull request template suggestion --- .github/ISSUE_TEMPLATE/bug_report.md | 2 ++ .github/ISSUE_TEMPLATE/feature_request.md | 4 ++- .github/pull_request_template.md | 44 +++++++++++++++++++++++ 3 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 .github/pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index a4771fa..7717abd 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -25,6 +25,8 @@ Please try this means to get help before opening an issue here: * On the networktocode Slack in the #netbox channel: http://slack.networktocode.com/ * On the Netbox mailing list: https://groups.google.com/d/forum/netbox-discuss +Please don't open an issue when you have a PR ready. Just submit the PR, that's good enough. + --> ## Current Behavior diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 65f31dd..6bc6dd4 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -24,6 +24,8 @@ Please try this means to get help before opening an issue here: * On the networktocode Slack in the #netbox channel: http://slack.networktocode.com/ * On the Netbox mailing list: https://groups.google.com/d/forum/netbox-discuss +Please don't open an issue when you have a PR ready. Just submit the PR, that's good enough. + --> ## Desired Behavior @@ -33,7 +35,7 @@ Please try this means to get help before opening an issue here: ## Contrast to Current Behavior - + ... ## Changes Required diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..9d85010 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,44 @@ + +Related Issue: + +## New Behavior + + + +... + +## Contrast to Current Behavior + + + +... + +## Discussion: Benefits and Drawbacks + + + +... + +## Changes to the Wiki + + + +... From 1064696c96773ac8b1602757bdc24d990b168545 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=A4der?= Date: Tue, 10 Dec 2019 23:16:11 +0100 Subject: [PATCH 2/2] N/A when there's no issue --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9d85010..1c3885f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,7 @@ +But if there is already a related issue, please put it's number here. E.g. #123 or N/A --> Related Issue: ## New Behavior